Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby, Rails and various gems #3

Merged
merged 5 commits into from
Nov 4, 2019
Merged

Conversation

peter-hank
Copy link
Contributor

@peter-hank peter-hank commented Oct 31, 2019

@peter-hank
Copy link
Contributor Author

Still on Rails 5.2.0 because of rzane/baby_squeel#97.

@peter-hank peter-hank requested a review from jdcc October 31, 2019 18:14
@peter-hank
Copy link
Contributor Author

@jdcc can you take a look?

I haven't tried to test any rake tasks, I'm not sure if any of them is still in use, if so, let me know.

@peter-hank
Copy link
Contributor Author

We will need to reindex the search index.

Copy link
Collaborator

@jdcc jdcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oai repo changes are on the master branch now, so that branch spec can go.

I'm having an issue getting this running. When I run bundle install, I get this:

You have requested:                                                
  rails = 5.2.3                                                            
                                                           
The bundle currently has rails locked at 5.2.0.
Try running `bundle update rails`

Do you see this if you try to update from the current dev, or is this a me issue?

@peter-hank
Copy link
Contributor Author

@jdcc

Yeah, my bad, incidently pushed the 5.2.3 Gemfile version. You can try again.

@peter-hank
Copy link
Contributor Author

I've tested it with PostgreSQL 12.0 and can't really see any issues. I've just exported the database from 9.3 and imported in 12. Hopefully we don't need anything else.

@jdcc jdcc merged commit bc2d4cc into dev Nov 4, 2019
@jdcc
Copy link
Collaborator

jdcc commented Nov 4, 2019

Looks good. I'll write up directions and have it deployed to QA.

@peter-hank peter-hank deleted the upgrade-rails-ruby-gems branch August 14, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants