Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle chunked responses in the context of redirect requests #742

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Handle chunked responses in the context of redirect requests #742

merged 2 commits into from
Jun 14, 2024

Conversation

bszaf
Copy link
Contributor

@bszaf bszaf commented May 31, 2024 •
edited
Loading

The asynchronous node was not handling situation, when the redirect requests were sent chunked.

The PR:

  1. Adds {more, Client2, Rest} -> case clause read more data if necessary.
  2. Allows to configure the continuation from async_recv/6 function, as by default it was going back to stream_loop what is not the case in redirect example.
  3. Adds unit test presenting the problem.

@bszaf
Handle chunked responses in the context of redirect requests.
d96a2fa 
The asynchronous was not handling situation, when the redirect
requests were sent chunked.
@bszaf bszaf changed the title Handle chunked responses in the context of redirect requests. Handle chunked responses in the context of redirect requests May 31, 2024
@benoitc benoitc self-assigned this Jun 9, 2024
@benoitc benoitc merged commit eca5fbb into benoitc:master Jun 14, 2024
0 of 5 checks passed
@bszaf bszaf deleted the async_redirect_fix branch July 8, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benoitc benoitc

Labels
testing working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bszaf @benoitc