Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1D example cases could use improvement #236

Open
mikekryjak opened this issue Jul 24, 2024 · 2 comments
Open

1D example cases could use improvement #236

mikekryjak opened this issue Jul 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mikekryjak
Copy link
Collaborator

1D-Recycling is our main 1D example case, but it has some issues that could confuse new users:

  • It uses PETSc by default which is not automatically installed by Hermes-3 when pulling the BOUT++ module
  • It has a much longer nout/timestep than needed for convergence
  • It doesn't have diagnose=true on several components, which may lead new users to think there are fewer diagnostics than exist
@mikekryjak mikekryjak added the enhancement New feature or request label Jul 24, 2024
@mikekryjak
Copy link
Collaborator Author

We should also add the sound_speed component with electron_dynamics = false. This will ensure that the lax flux damping considers the combined species sound speed, not just each species' individual speeds. electron_dynamics = true also includes electron sound speed, but this should only be used if you're evolving electron momentum.

@mikekryjak
Copy link
Collaborator Author

Partially solved by #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant