Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: setup docker image #144

Open
henryclw opened this issue Nov 24, 2022 · 2 comments
Open

Proposal: setup docker image #144

henryclw opened this issue Nov 24, 2022 · 2 comments

Comments

@henryclw
Copy link

I want to have a new feature that use docker image to build and deploy this project, any ideas?

I could create a pull request if this feature is wanted.

@bdebon
Copy link
Owner

bdebon commented Nov 25, 2022

What would be the benefit of this? I'm genuely curious about it so don't hesitate to describe well !

@henryclw
Copy link
Author

What would be the benefit of this? I'm genuely curious about it so don't hesitate to describe well !

In my opinion, the most significant benefit of setting up docker image is to let more people deploy this project easily. They don't have to pull the git repo, don't have to install node environment, even don't need to have a lot of knowledge about front-end. The could just run the command

docker pull someone/someexampleimage
docker run -p 80:80 someone/someexampleimage

Then everything is set up.

This also makes the devops much easier, since we could use docker image for CI/CD and k8s and so on.

Feel free to give any feedback if you have any comment about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants