Fix "emebed" to "embed" #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcsgh
reviewed
Jun 18, 2022
| @@ -36,8 +36,8 @@ cc_flags_supplier( | |||
| ) | |||
|
|
|||
| cc_binary( | |||
| name = "make_emebed_data", | |||
| srcs = ["make_emebed_data.cc"], | |||
| name = "make_embed_data", | |||
There was a problem hiding this comment.
Please add a deprecated alias to in place of the old rule.
https://docs.bazel.build/versions/main/be/general.html#alias
Include in the deprecation message a short explanation of this change. ... That is assuming that the deprecation message gets printed before Bazel errors out due to something depending on the renamed files. If it usually fails that way, just say so here and no need to bother.
There was a problem hiding this comment.
Out of curiosity: from where did you find this library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
.bzlcode makes this a breaking change, but one that should be easy for dependent projects to identify and fix (I'd hope; the test file#includeshows the change required).