Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence not possible when using probability based binomial scoring #53

Open
JustinChu opened this issue Jun 4, 2020 · 0 comments
Open
Assignees
Labels

Comments

@JustinChu
Copy link
Collaborator

JustinChu commented Jun 4, 2020

When the minimum FPR is too low for the length of a read + the false postive rate of the bf, the program aborts. Somewhat related to issue #51 .

To resolve this elegantly I could ignore read with lengths that cannot fulfil minmum FPR. However for the miBF code, some IDs for a minimum read length may be valid at a minimum FPR. To resolve these cases, I could ignore only IDs with this case. However both these cases are not likely what the user would intend.

@JustinChu JustinChu self-assigned this Jun 4, 2020
@JustinChu JustinChu added the bug label Jun 4, 2020
@JustinChu JustinChu modified the milestones: 2.4.0, 2.3.3 Jun 4, 2020
@JustinChu JustinChu removed this from the 2.3.3 milestone Aug 1, 2020
@JustinChu JustinChu assigned JustinChu and unassigned JustinChu Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant