Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6025] - permit condition reports #3288

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

matbusby-fw
Copy link
Collaborator

@matbusby-fw matbusby-fw commented Oct 30, 2024

Objective

Added functionality to tie permit required reports directly to specific permit conditions.

  • updated mine_reports table with new optional values for condition specific reports
  • updated return for mine permits to include reports
  • added action bar on permit conditions that is opened when a condition is clicked on (only the add report and cancel buttons currently implemented)
  • added a view for condition specific reports at the bottom of each section
  • added edit mode for the view (updating reports not yet implemented)

MDS-6205

permit-reports

…rface to expand and show action buttons when clicking into a condition.
Enhanced permit conditions to include associated reports. Updated the UI to display report-related information and modified relevant constants, styles, and selectors accordingly.
Enhanced permit conditions to include associated reports. Updated the UI to display report-related information and modified relevant constants, styles, and selectors accordingly.
Renamed `AddRequestToPermitConditionForm` to `AddReportToPermitConditionForm` to better reflect its purpose. Also updated all references and added a default export for consistency. Added a snapshot test for the form component.
… exists

This commit introduces a new optional `report` prop to the `AddReportToPermitConditionForm` component, allowing it to use an existing report if available. Additionally, it modifies the permit condition layer to disable the "Add Report" button when a report already exists for the sub-condition, and ensures permits are refetched after adding a new report.
@matbusby-fw matbusby-fw changed the title Mds 6205 permit reports [MDS-6025] - permit condition reports Oct 30, 2024
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
35.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
1 Security Hotspot
69.6% Coverage on New Code (required ≥ 80%)
4.6% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matbusby-fw matbusby-fw marked this pull request as ready for review October 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant