Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-4971] Help Guide bugs #3283

Merged
merged 5 commits into from
Oct 29, 2024
Merged

[MDS-4971] Help Guide bugs #3283

merged 5 commits into from
Oct 29, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 25, 2024

Objective

Clean up high-priority/easy bugs for help guide:

  • remove "align" as it didn't do anything (maybe it left-aligned it but it was already left-aligned? Not sure, but left align is best align anyway)
  • remove video- complicated (the dom sanitizer strips it and I think I saw a CORS or similar error in the editor on test)
  • customize colours available for selection 🌈
  • style the blockquote
  • add in cancel edit with confirm wrapper
  • make ? button styling consistent on active/focus state too
  • copy over list styling from the react-quill stylesheet

MDS-4971

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
13.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@taraepp taraepp merged commit b59f848 into develop Oct 29, 2024
14 of 15 checks passed
@taraepp taraepp deleted the mds-4971-help-bugs branch October 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants