Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRUD Operations to Deployment Controller for SIMS #93

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add CRUD Operations to Deployment Controller for SIMS #93

wants to merge 1 commit into from

Conversation

mauberti-bc
Copy link
Collaborator

Description of changes

  • Adds create, update and delete operations for managing deployments in SIMS

Notes:

  • Work in progress that intends to isolate and improve API components used by SIMS
  • Probably need to switch from soft deletes to hard deletes for some of the repository functions to work (eg. getDeploymentById)

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 10, 2024
View reviewed changes
bctw-api/src/server.ts
ROUTES.importXML,
auth('SIMS_SERVICE'),
upload.array('xml'),
api.parseVectronicKeyRegistrationXML

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
Loading
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mauberti-bc