Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AMP iframe and Psammead components to MediaLoader #11994

Draft
wants to merge 23 commits into
base: latest
Choose a base branch
from
Draft

Move AMP iframe and Psammead components to MediaLoader #11994

wants to merge 23 commits into from

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented Sep 19, 2024 •
edited
Loading

Overall changes

  • Moves amp-iframe to MediaLoader for AMP media rendering
  • Moves PlayButton, Message and Guidance components out of Psammead and into MediaLoader (these old Psammead components can be removed once we are no longer using the legacy MediaPlayer and AVPlayer components on other page types)
  • Updates snapshots where necessary

Code changes

  • A bullet point list of key code changes that have been made.

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amoore108 amoore108

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amoore108