Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Replace all the any with TS types #49

Open
epatrasc opened this issue Nov 8, 2019 · 2 comments
Open

[Maintenance] Replace all the any with TS types #49

epatrasc opened this issue Nov 8, 2019 · 2 comments

Comments

@epatrasc
Copy link
Contributor

epatrasc commented Nov 8, 2019

Is your feature request related to a problem? Please describe.

We have lots of "any" as type, we should fix this.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add the correct type for all the any

@edmorrish
Copy link
Contributor

Have started a branch with tsc in strict mode to try to resolve some of this: https://github.com/bbc/lrud/tree/strict-types

@edmorrish
Copy link
Contributor

Types are extremely messy across the board to be honest, almost everything is nullable or undefined at all times so it'd probably be a good idea to do a review of the Lrud data structure and come up with some sensible defaults for the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants