New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in Prime Tests, gcd != 1 #31

Open

furun opened this issue Jun 30, 2020 · 1 comment

furun commented Jun 30, 2020

There is a bug in some prime tests.

This lines are wrong, it fails to detect if gcdTest.dataLength > 1

if (gcdTest.dataLength == 1 && gcdTest.data[0] != 1)

it should be

if (gcdTest.dataLength > 1 || gcdTest.dataLength == 1 && gcdTest.data[0] != 1)

(I replaced all this check with IsNegative, IsOne, IsOdd, etc.
Sad that this code is not supposed anymore, it is the best c# code I know)

Owner

bazzilic commented Mar 11, 2022 •

edited

Loading

Hi, .NET now has its own, built-in BigInteger class, which is better than what was implemented here. It lacks some functions, which can be found in our other project (https://github.com/aprismatic/bigintegerext) that extends the built-in class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment