-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgo=0 of github.com/cloudflare/circl does not compile #3799
Comments
Yeah, the cgo structure of circl is not supported by Gazelle. You can use Bzlmod and depend on the |
jrockway
added a commit
to pachyderm/pachyderm
that referenced
this issue
May 3, 2024
There was an issue with a dependency of Pulumi that prevented us from building with Bazel. That is fixed, or at least worked around cleanly: bazelbuild/rules_go#3799 (comment) With the workarounds, this now builds OK, so I've unignored it and added a BUILD file. There was also an issue where it generates invalid helm values. I fixed that bug and added a test.
jrockway
added a commit
to pachyderm/pachyderm
that referenced
this issue
May 3, 2024
There was an issue with a dependency of Pulumi that prevented us from building with Bazel. That is fixed, or at least worked around cleanly: bazelbuild/rules_go#3799 (comment) With the workarounds, this now builds OK, so I've unignored it and added a BUILD file. There was also an issue where it generates invalid helm values. I fixed that bug and added a test.
jrockway
added a commit
to pachyderm/pachyderm
that referenced
this issue
May 3, 2024
There was an issue with a dependency of Pulumi that prevented us from building with Bazel. That is fixed, or at least worked around cleanly: bazelbuild/rules_go#3799 (comment) With the workarounds, this now builds OK, so I've unignored it and added a BUILD file. There was also an issue where it generates invalid helm values. I fixed that bug and added a test. Backports #10017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of rules_go are you using?
v0.43.0
What version of gazelle are you using?
v0.34.0
What version of Bazel are you using?
7.0.0
Does this issue reproduce with the latest releases of all the above?
yes
What operating system and processor architecture are you using?
x86 / linux
What did you do?
I pulled in a go_repository that depended on github.com/cloudflare/circl
(
CGO_ENABLED=0 go build ./...
works in circl).Compiling, I got:
So I tracked down the fact that assembly files in cgo packages are not included in pure compilation (#3798 -- though I don't think it's entirely correct), after which the following happens:
Presumably because https://github.com/cloudflare/circl/blob/main/math/fp25519/fp_noasm.go is not included in compilation. (Which puzzles me actually, because I don't understand how it is included in regular CGO_ENABLED=0 compilation of the package. I haven't been able to track that down.)
The text was updated successfully, but these errors were encountered: