Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make go_deps restarts less costly #1667

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Make go_deps restarts less costly #1667

wants to merge 5 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 21, 2023

No description provided.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2023

@linzhp Could you test whether this reduces the runtime of the extension?

@linzhp
Copy link
Contributor

linzhp commented Nov 21, 2023

Still got 11 go_deps, the longest became:

    {"cat":"bazel module processing","name":"evaluate module extension: @@gazelle~0.34.0//:extensions.bzl%go_deps","ph":"X","ts":7769016,"dur":283072,"pid":1,"tid":306},

Before this PR, the longest was:

    {"cat":"bazel module processing","name":"evaluate module extension: @@gazelle~0.34.0//:extensions.bzl%go_deps","ph":"X","ts":7541933,"dur":140592,"pid":1,"tid":288},

So it doesn't reduce the runtime.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2023

@linzhp Could you also check the sun of the durations? This PR making it worse is pretty unexpected... We can't do anything about the number of restarts unfortunately.

@linzhp
Copy link
Contributor

linzhp commented Nov 21, 2023

All go_deps restarts run sequentially, so I get the timestamp of the last instance plus its duration subtracted by the timestamp of the first instance

Before this PR, I got 891225; after this PR, I got 1557146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants