Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the toolchain rules in a single separate package so users can use the :all target pattern when registering them #134

Open
rrbutani opened this issue Jan 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@rrbutani
Copy link
Collaborator

local_config_cc_toolchains does this (toolchains are defined here and here).

This is desirable because it makes it possible to just use @llvm_toolchain//toolchains:all (for example) when using this toolchain with a toolchain transition that sets --extra_toolchains rather than meticulously maintaining a select call that matches the toolchains that this repo emits for each platform/configuration.

We should also update the blurb in the readme that mentions using --extra_toolchains=... to match once we do this.

(this isn't high-priority; just something I ran into while trying to put together a proof of concept for #130)

@rrbutani rrbutani added the enhancement New feature or request label Jan 22, 2022
@rrbutani rrbutani changed the title Generate the toolchain rules in a single separate package so users can use the :all target patten when registering them Generate the toolchain rules in a single separate package so users can use the :all target pattern when registering them Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant