support rb_binary with Gemfiles in subdirectory
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgao54
force-pushed
the
joygao/handle-nested-path
branch
2 times, most recently
from
3aec469
to
21114eb
Compare
jgao54
force-pushed
the
joygao/handle-nested-path
branch
from
21114eb
to
6be0963
Compare
jgao54
changed the title
rb_binary from subdirrb_binary with Gemfiles in subdirectory
|
failure is unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround to support nested Gemfiles; a bit hacky since this expects a Gemfile in the transitive srcs. Ideally we'd want to provide this information via the rb_bundle repository rather than explicitly passing it in via
srcs.