Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check buildifier on CI #21

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

alexeagle
Copy link
Collaborator

Matches how it's done in the bazel-contrib/rules-template

Matches how it's done in the bazel-contrib/rules-template
@p0deje
Copy link
Member

p0deje commented Nov 18, 2023

I'll merge it once CI passes.
I think it would be great to be able to run this locally too, so I'll follow up to move the target from .github/workflows to the root BUILD unless you have objections.

@alexeagle
Copy link
Collaborator Author

The pre-commit hook has a separate way of fetching Buildifier (no Bazel involved) so if you pre-commit install, you won't want a target in the root anymore.

That said, it doesn't really matter which of these two build files it goes in

@p0deje p0deje merged commit 772d4eb into bazel-contrib:main Nov 18, 2023
16 checks passed
@alexeagle alexeagle deleted the buildifier_check branch November 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants