Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify node base name in devrel and base port. #1013

Open
wants to merge 1 commit into
base: develop-3.0
Choose a base branch
from

Conversation

martincox
Copy link
Contributor

Set the nodename prefix and base port for devrels.

@martinsumner
Copy link
Contributor

Is this still required?

Copy link
Contributor

@Bob-The-Marauder Bob-The-Marauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a nice toy, I too fail to see a major use for this.
Also, I don't see any port protection to avoid conflicts if the user specifies a port that clashes with other services. Admitedly, the original version didn't have that either but the hardcoded ports were chosen so that was rarely an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants