Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for compatibility with Turbo morphing #155

Conversation

northeastprince
Copy link

No description provided.

@josefarias
Copy link
Contributor

Hey @northeastprince, @jorgemanrubia helpfully pointed out internally that my worries about adding too many observers in #152 (review) might not be an issue. Stimulus adds observers all the time after all and it hasn't been a problem. So we might go back to that approach.

I'll make some measurements soon and make the call. You're welcome to try and find the best place to create those observers (ideally one per element, to avoid complexity). I might also be working on this soon, so if I happen to get to this first you can be sure I'll add you as co-author. Thanks!

@josefarias
Copy link
Contributor

At this point it seems we're going to go with #156, although it still needs some work. I've added you as co-author in that PR.

Closing this for now in favor of that PR.

@josefarias josefarias closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants