modified: "imports-exercise.md" to include a custom-styled block of text to inform @dev about contract verification best practices #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included a custom-styled block of text to inform @dev about contract verification best practices
|
|
briandoyle81CB
approved these changes
Jan 25, 2024
taycaldwell
approved these changes
Jan 25, 2024
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
Included a custom-styled block of text to inform @dev about contract verification best practices Co-authored-by: Gnarizard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I updated the imports-exercise doc to include a custom-styled block of text to inform @dev about contract verification best practices.
Notes to reviewers
I kept running into this issue with contract verification where I couldnt verified my contract that included import statements unless I flattened the contract or deployed the "imported" contracts individually and then interacted in my "main" contract via their deployed addresses.
I tried to use concise, yet descriptive language. If this was known to me initially while working on the contract exercises it wouldve saved me time and frustration so thats why I figured the update is valuable.
Thanks team! Im honored to be able to contribute.
How has it been tested?
I tested the changes locally using a Markdown preview extension.
Does this PR add a new token to the bridge?
Please include evidence of both confirmations above for your reviewers.