Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StartBuilding section to reduce code duplication #1226

Closed
wants to merge 1 commit into from

Conversation

NikolaiKryshnev
Copy link
Contributor

  1. Replaced repeated ResourceCard components with a dynamic approach using an array of resources.
  2. Improved readability and maintainability by using .map() to render resource cards dynamically.
  3. Simplified the structure and made it easier to add new resources without modifying the JSX directly.
  4. Removed hardcoded CSS classes and passed them dynamically via props.

1. Replaced repeated `ResourceCard` components with a dynamic approach using an array of resources.
2. Improved readability and maintainability by using `.map()` to render resource cards dynamically.
3. Simplified the structure and made it easier to add new resources without modifying the JSX directly.
4. Removed hardcoded CSS classes and passed them dynamically via props.
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:43am

Copy link

vercel bot commented Nov 8, 2024

@NikolaiKryshnev is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 8, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added state: backlog This is pending further review community contribution This is a contribution from the community labels Nov 8, 2024
@wbnns
Copy link
Member

wbnns commented Nov 8, 2024

@NikolaiKryshnev

Thanks for this PR! Confirming this is now in our backlog, pending to be reviewed.

@zencephalon
Copy link
Collaborator

https://gist.github.com/kevmo314/7bbf5d5868b973b53898d12b977b15b7

@zencephalon zencephalon closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This is a contribution from the community state: backlog This is pending further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants