-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basenames frames tutorial #1005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hughescoin is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
✅ Heimdall Review Status
|
JFrankfurt
approved these changes
Sep 20, 2024
Review Error for JFrankfurt @ 2024-09-20 16:55:59 UTC |
JFrankfurt
approved these changes
Sep 20, 2024
ericbrown99
pushed a commit
to ericbrown99/base-web
that referenced
this pull request
Sep 26, 2024
* add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions
hughescoin
added a commit
that referenced
this pull request
Sep 27, 2024
* Create quickstart guide * Complete first draft of quick start guide * Edit tutorial doc details * Fix typos and ensure consistent styles * Update the Why Base? tool tip * fix emoji encoding (#996) * Basename: Fix analytics events (#997) * remove page events in favor of pageview * fix invalid logging * fixed env var references (#1003) * updated bg and image for gs hero (#1001) * Update Irys Dyanmic NFT example to use the latest version of Irys's tooling (#1000) * Fix typos and demo code in docs (#995) * Fix demo code in useWriteContract docs * Fix typos * Fix demo code * Fix import path * Correction of typos (#992) * error-triage.md Correction * hardhat-verify-sbs.md Correction * data.json Correction * 5_cross-chain-with-layerzero.md Correction * feat: embedded farcaster frames (#762) * initial draft of frame render * render frames from text records * fix build, https instead of * csp * undo changes to base-docs * no-verify repeat * add xmtp signer * fix build issue and add frame prompt element * Extract TryNowHero component * add second add-frame button * Frame previews in modal * Frame previews in modal * Rough out copy and text hierachy * More blocking * fix property access on profile context * add responsive layout * Setup suggestion cards * clean up pr * clean up pr * Update card icons * Make AddFrameModal components modular * fully functional farcaster frames * get previews working * polish * Target arm64 architecture for web (#967) * theme update * try openframes first * wip towards frame management page * Revert "wip towards frame management page" This reverts commit de4b6eb. * Revert "Revert "wip towards frame management page"" This reverts commit 52a4555. * make page render * get desktop frame builder ui working * frame manager page w/ loading and some styles * add back button * better theme and add multi-add * fix loading experience * add mobile ux * incorporate d furlong's suggestion re: frameImage fix * dogfooding input from Rhea * improved validation and copy * improved loading state * improve button and input styling * add farcaster logout ux * clean up sign-in ux * clean up qr modal * add swap frame * clean up frame image sizing * add a nice smooth transition in/out of loading states * BAPP-579 * BAPP-585, BAPP-586 * BAPP-583 * BAPP-583 * move error handling up a level * analytics * improve mobile builder ux * fix farcaster signer modal close issue--poll for text record changes on owned profiles * center sign in with warpcast text * yarn * pr review from Leo * lint * add back nomination frame * stick buttons to the bottom and center the loader * revert csp changes * add more logging and remove dead code * be less spooky about the missing env vars * add more info to error/analytics calls * optimistic addition/removal of frames; improved warpcast sign-in * remove columns experimentation * fix masonry layout * update icons for shelley * rm unnecessary classnames call * frame border radius nit * style nits * add dropped icon * bunday review --------- Co-authored-by: Matthew Bunday <[email protected]> Co-authored-by: David Roth <[email protected]> * Basenames frames tutorial (#1005) * add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions * fix: errors shouldn't mess with open frame support flag (#1008) * Frames tutorial updates (#1010) * update Claim Basename call to action * update grammar on intro and second paragraph * change example basename * remove UL and turn into sentences * Add owner registry componentId to cbgpt request (#1011) * Remove the get an onchain summer pass (#1012) * Fix typos * Rebuild with correct checksum in tutorials data.json * Fix artifacts in yarn.lock --------- Co-authored-by: Léo Galley <[email protected]> Co-authored-by: Brendan from DeFi <[email protected]> Co-authored-by: Luke Cassady-Dorion <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Cypher Pepe <[email protected]> Co-authored-by: Jordan Frankfurt <[email protected]> Co-authored-by: Matthew Bunday <[email protected]> Co-authored-by: David Roth <[email protected]> Co-authored-by: Pat <[email protected]> Co-authored-by: moggr <[email protected]>
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions
kirkas
added a commit
that referenced
this pull request
Oct 21, 2024
* Create quickstart guide * Complete first draft of quick start guide * Edit tutorial doc details * Fix typos and ensure consistent styles * Update the Why Base? tool tip * fix emoji encoding (#996) * Basename: Fix analytics events (#997) * remove page events in favor of pageview * fix invalid logging * fixed env var references (#1003) * updated bg and image for gs hero (#1001) * Update Irys Dyanmic NFT example to use the latest version of Irys's tooling (#1000) * Fix typos and demo code in docs (#995) * Fix demo code in useWriteContract docs * Fix typos * Fix demo code * Fix import path * Correction of typos (#992) * error-triage.md Correction * hardhat-verify-sbs.md Correction * data.json Correction * 5_cross-chain-with-layerzero.md Correction * feat: embedded farcaster frames (#762) * initial draft of frame render * render frames from text records * fix build, https instead of * csp * undo changes to base-docs * no-verify repeat * add xmtp signer * fix build issue and add frame prompt element * Extract TryNowHero component * add second add-frame button * Frame previews in modal * Frame previews in modal * Rough out copy and text hierachy * More blocking * fix property access on profile context * add responsive layout * Setup suggestion cards * clean up pr * clean up pr * Update card icons * Make AddFrameModal components modular * fully functional farcaster frames * get previews working * polish * Target arm64 architecture for web (#967) * theme update * try openframes first * wip towards frame management page * Revert "wip towards frame management page" This reverts commit 4d0fceb493db72bc7d84884425d521f4ecc999b8. * Revert "Revert "wip towards frame management page"" This reverts commit a692a9df1cd7e13cc019335b58f9c7087795593f. * make page render * get desktop frame builder ui working * frame manager page w/ loading and some styles * add back button * better theme and add multi-add * fix loading experience * add mobile ux * incorporate d furlong's suggestion re: frameImage fix * dogfooding input from Rhea * improved validation and copy * improved loading state * improve button and input styling * add farcaster logout ux * clean up sign-in ux * clean up qr modal * add swap frame * clean up frame image sizing * add a nice smooth transition in/out of loading states * BAPP-579 * BAPP-585, BAPP-586 * BAPP-583 * BAPP-583 * move error handling up a level * analytics * improve mobile builder ux * fix farcaster signer modal close issue--poll for text record changes on owned profiles * center sign in with warpcast text * yarn * pr review from Leo * lint * add back nomination frame * stick buttons to the bottom and center the loader * revert csp changes * add more logging and remove dead code * be less spooky about the missing env vars * add more info to error/analytics calls * optimistic addition/removal of frames; improved warpcast sign-in * remove columns experimentation * fix masonry layout * update icons for shelley * rm unnecessary classnames call * frame border radius nit * style nits * add dropped icon * bunday review --------- Co-authored-by: Matthew Bunday <[email protected]> Co-authored-by: David Roth <[email protected]> * Basenames frames tutorial (#1005) * add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions * fix: errors shouldn't mess with open frame support flag (#1008) * Frames tutorial updates (#1010) * update Claim Basename call to action * update grammar on intro and second paragraph * change example basename * remove UL and turn into sentences * Add owner registry componentId to cbgpt request (#1011) * Remove the get an onchain summer pass (#1012) * Fix typos * Rebuild with correct checksum in tutorials data.json * Fix artifacts in yarn.lock --------- Co-authored-by: Léo Galley <[email protected]> Co-authored-by: Brendan from DeFi <[email protected]> Co-authored-by: Luke Cassady-Dorion <[email protected]> Co-authored-by: Luigi <[email protected]> Co-authored-by: Cypher Pepe <[email protected]> Co-authored-by: Jordan Frankfurt <[email protected]> Co-authored-by: Matthew Bunday <[email protected]> Co-authored-by: David Roth <[email protected]> Co-authored-by: Pat <[email protected]> Co-authored-by: moggr <[email protected]>
zencephalon
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add basenames frames tutorial without images * add images to asset folder * add images to tutorial * add image of profile completion * make basenames singular * update slug to lowercase b in basename * add reference links * add basenames faq question * reword what are frames paragraph * add open spec link * remove profile mentions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
A tutorial on how to add a Frame to a Basename profile
Notes to reviewers
How has it been tested?