Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Request: Payable, and an explicit comparison of transfer(), send(), and call() #260

Open
briandoyle81CB opened this issue Jan 18, 2024 · 7 comments
Labels
state: backlog This is pending further review type: docs New docs or changes to existing

Comments

@briandoyle81CB
Copy link
Contributor

What is the issue you are encountering with the docs?

Add a section on payable, and an explicit comparison of transfer(), send(), and call()?

Links to Impacted Docs

n/a

Describe the solution you'd like to see.

Payable, and an explicit comparison of transfer(), send(), and call()

Additional context

No response

@briandoyle81CB briandoyle81CB added the type: docs New docs or changes to existing label Jan 18, 2024
@hoysal08
Copy link
Contributor

@briandoyle81CB , I would like to contribute to this, i have added an article for Payable. Let me know if something needs to be changed. I will add an article for comparison of transfer(), send(), and call() also.
#275

@briandoyle81CB
Copy link
Contributor Author

@hoysal08, do you still intend to write the second article? No worries if not, I just don't want to open it up to others if you're working on it.

@twynne20
Copy link
Contributor

twynne20 commented Feb 27, 2024

Hey @hoysal08! Happy to pick up this article or collaborate on it if you are working on other things... Will give it a few days to hear back and start after ETHDenver wraps up if I don't hear back!

If you are going to continue you with it then I look forward to reading!

@twynne20
Copy link
Contributor

twynne20 commented Mar 5, 2024

@hoysal08 checking back in as I'm back from ETHDenver. Will start this evening if I don't hear back!

Let me know if you want to collab

@hoysal08
Copy link
Contributor

hoysal08 commented Mar 6, 2024

Hey @twynne20 , sorry for the delay. I was held up with something else.
I have already written the article, will be posting a PR today.

@twynne20
Copy link
Contributor

twynne20 commented Mar 6, 2024

Thanks for the response @hoysal08. Perhaps I will do some PRs once yours is merged if I see any value I can add. I wrote up an initial article as well. If you are still adding to your PR here is the current article I wrote if you want to check it out in Notion. (Didn't PR yet)

Feel free to pull any info you like from it:
https://phrygian-chevre-062.notion.site/Sending-Ether-transfer-send-call-73cf9ece547c4eee96a6bd34863b3d89?pvs=4

@hoysal08
Copy link
Contributor

hoysal08 commented Mar 6, 2024

@twynne20 , I already raised a PR on this. But the initial article you have seems very good too.
Please feel free to update PR or add your points once this is merged.
You can find the PR here #347

@wbnns wbnns added the state: backlog This is pending further review label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: backlog This is pending further review type: docs New docs or changes to existing
Projects
None yet
Development

No branches or pull requests

4 participants