Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Update core logic to be less verbose & more simple in abstraction #182

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Update core logic to be less verbose & more simple in abstraction #182

merged 13 commits into from
Nov 15, 2023

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Nov 4, 2023 •
edited
Loading

Abstraction Rewrite

Fixes Issues

Changes proposed

  • Remove BalanceOracle processor in-favor of only doing balance queries upon new block events
  • Change component to process
  • Change pipeline to path
  • Removed block processor in-favor OP Indexer's header traversal algorithm
  • Updated most ETL code to be less verbose and more simplistic in terms of variable naming

Screenshots (Optional)

Note to reviewers

While code logic was changed no tests were

Ethen Pociask added 12 commits November 2, 2023 02:31
[etl_optimisations] Removed component, changed abstrations, & redid b…
46842a7 
…lock syncing
[etl_optimisations] block_traversal -> header_traversal
b6569a0
Merge branch 'master' of https://github.com/base-org/pessimism into e…
7f311be 
…tl_optimisations
[etl_optimisations] refactored testing
babd19a
[etl_optimisations] rm unnecessary files
00233e2
[etl_optimisations] Fix lint errors
bf3edcd
[reworked-core-abstractions] reworked core abstractions
ef016f4
[reworked-core-abstractions] changed all code references to use new E…
e3dc581 
…TL abstractions
[reworked-core-abstractions] removed all references of pipeline & com…
7ec4f79 
…ponent
[reworked-core-abstractions] passing lint and tests
54519d3
[reworked-core-abstractions] remove binary
a6976b9
[reworked-core-abstractions] updated docs
554282f
@epociask epociask changed the title Fix - Reworked core abstractions Update core logic to be less verbose and more simple in abstraction Nov 7, 2023
@epociask epociask changed the title Update core logic to be less verbose and more simple in abstraction Update core logic to be less verbose & more simple in abstraction Nov 7, 2023
@epociask epociask marked this pull request as ready for review November 7, 2023 02:43
@epociask epociask self-assigned this Nov 7, 2023
@nadir-akhtar-coinbase nadir-akhtar-coinbase merged commit d1ec230 into master Nov 15, 2023
9 checks passed
@nadir-akhtar-coinbase nadir-akhtar-coinbase deleted the reworked-core-abstractions branch November 15, 2023 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadir-akhtar-coinbase nadir-akhtar-coinbase nadir-akhtar-coinbase approved these changes

@sagrawal87 sagrawal87 Awaiting requested review from sagrawal87

@adrain-cb adrain-cb Awaiting requested review from adrain-cb

@awilliams1-cb awilliams1-cb Awaiting requested review from awilliams1-cb

Assignees

@epociask epociask

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epociask @nadir-akhtar-coinbase