Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Refactored Invariant Registry & Added Fault Detector Implementation #104

Merged
merged 49 commits into from
Jul 10, 2023
Merged

Refactored Invariant Registry & Added Fault Detector Implementation #104

merged 49 commits into from
Jul 10, 2023

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Jul 3, 2023 •
edited
Loading

Fixes Issues

Fixes #

Changes proposed

  • Added a CI action to upload test coverage percentages in each PR
  • Added an implementation of fault detection
  • Refactored invariant registry implementation and added a lot of unit tests

Screenshots (Optional)

Note to reviewers

@epociask epociask marked this pull request as ready for review July 4, 2023 07:41
@epociask epociask requested a review from adrain-cb July 4, 2023 08:47
@epociask epociask changed the title Refactored Invariant Registry Refactored Invariant Registry & Added More Unit Tests Jul 4, 2023
Ethen Pociask added 13 commits July 5, 2023 04:24
[epociask/no-issue-refactored-invariant] Engine manager eventLoop test
0c9f719
[epociask/no-issue-refactored-invariant] Added coverage-report
afb0cbb
[epociask/no-issue-refactored-invariant] Removed coverage file
b7fc902
[epociask/no-issue-refactored-invariant] Updated workflow
3a4cfca
[epociask/no-issue-refactored-invariant] Updated workflow
c741cf7
[epociask/no-issue-refactored-invariant] Updated test
dea396b
[epociask/no-issue-refactored-invariant] testing actions
307f26b
[epociask/no-issue-refactored-invariant] testing actions
45a4ea5
[epociask/no-issue-refactored-invariant] testing
3f9143b
[epociask/no-issue-refactored-invariant] debugging test
31db1fc
[epociask/no-issue-refactored-invariant] debugging test
61d6ece
[epociask/no-issue-refactored-invariant] Fixed workflow formatting bugs
f91413b
[epociask/no-issue-refactored-invariant] Coverage works
3ac6af3
@base-org base-org deleted a comment from github-actions bot Jul 6, 2023
@base-org base-org deleted a comment from github-actions bot Jul 6, 2023
@base-org base-org deleted a comment from github-actions bot Jul 6, 2023
@base-org base-org deleted a comment from github-actions bot Jul 6, 2023
@base-org base-org deleted a comment from github-actions bot Jul 6, 2023
Ethen Pociask added 17 commits July 6, 2023 01:44
[epociask/no-issue-refactored-invariant] Update script logic
0419ada
[epociask/no-issue-refactored-invariant] Core tests
168e131
[epociask/no-issue-refactored-invariant] Removed configure routine
1f0898e
[epociask/no-issue-refactored-invariant] More subsystem tests
1405781
[epociask/no-issue-refactored-invariant] More tests
bae28e6
[epociask/no-issue-refactored-invariant] Added common test
825006b
[epociask/no-issue-refactored-invariant] model tests
d90c975
[epociask/no-issue-refactored-invariant] Update coverage command
bb352b4
[epociask/no-issue-refactored-invariant] Update coverage command
5d215b7
[epociask/no-issue-refactored-invariant] Update coverage command
e0cbe1b
[epociask/no-issue-refactored-invariant] Update
2535791
[epociask/no-issue-refactored-invariant] Fault Detector Implementation
5356a21
[epociask/no-issue-refactored-invariant] Removed configure routine
f640af2
[epociask/no-issue-refactored-invariant] Updated fault-detector
b58c57c
[epociask/no-issue-refactored-invariant] go tool cover -func=coverage…
dbb1fad 
….out | grep total | >> out.txt
[epociask/no-issue-refactored-invariant] Passing lint
5f4d792
[epociask/no-issue-refactored-invariant] Fix typos
09cf1c1
@epociask epociask changed the title Refactored Invariant Registry & Added More Unit Tests Refactored Invariant Registry & Added Fault Detector Implementation Jul 10, 2023
adrain-cb
adrain-cb previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@adrain-cb adrain-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@epociask epociask requested a review from adrain-cb July 10, 2023 20:21
@epociask epociask merged commit a72d126 into master Jul 10, 2023
6 checks passed
@epociask epociask deleted the epociask/no-issue-refactored-invariant branch July 10, 2023 20:31
This was referenced Jul 11, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrain-cb adrain-cb adrain-cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epociask @adrain-cb