Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiarch docker image build #1059

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Multiarch docker image build #1059

merged 3 commits into from
Oct 10, 2023

Conversation

akatona84
Copy link
Contributor

@akatona84 akatona84 commented Sep 15, 2023 •
edited by pregnor
Loading

Description

Mutliarch docker image build of kafka-operator.

#1058

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other : build enhancement

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests

@akatona84 akatona84 requested a review from a team as a code owner September 15, 2023 06:33
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@akatona84 akatona84 changed the title Multiarch build WIP - Multiarch build Sep 15, 2023
@akatona84 akatona84 changed the title WIP - Multiarch build Multiarch docker image build Sep 15, 2023
pregnor
pregnor approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akatona84 thanks for the contribution, please sign the CLA or click recheck if you already did.

CC: @chrisgacsal @bartam1

@pregnor
Copy link
Member

pregnor commented Sep 15, 2023

Note: I edited the description to remove unchecked boxes so Mergable would be satisfied.

bartam1
bartam1 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@bartam1 bartam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akatona84
Copy link
Contributor Author

What else is needed to submit this?

@bartam1 bartam1 merged commit 6b2b109 into banzaicloud:master Oct 10, 2023
6 checks passed
@akatona84 akatona84 deleted the multiarch branch October 11, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@bartam1 bartam1 bartam1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akatona84 @CLAassistant @pregnor @bartam1