New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for testing NodeViews #125

Open

kepta opened this issue Dec 21, 2020 · 0 comments

Collaborator

kepta commented Dec 21, 2020 •

edited

Loading

PM NodeViews are tricky! I am fairly confident about the current react node view implementation but it helps to add more tests.

I imagine four kinds of tests:

Atom inline node with no editable content.
Inline node with editable content.
Block level atom node without content. Example https://prosemirror.net/examples/codemirror/
Block level node with editable content. Example https://banglejs.dev/docs/guides/custom-rendering-speech

Some helpful discussions for reference: remirror, tiptap, pm-react-nodeview

kepta added the testing label

kepta removed the testing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment