Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Language model with one from Deisgn system #62

Open
nobilo opened this issue Nov 3, 2023 · 0 comments
Open

Align Language model with one from Deisgn system #62

nobilo opened this issue Nov 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nobilo
Copy link
Collaborator

nobilo commented Nov 3, 2023

Use this template if you want to request a new feature, or a change to an existing feature.

LanguagesOfSwitzerland

Summary

We have https://github.com/baloise/web-app-utils/blob/master/packages/utils/src/language/language-model.ts and we have specific types for languages in design system:

https://github.com/baloise/design-system/blob/669c63fd734137e886fc50dc0075631e8b0acc07/packages/components/src/utils/config/config.types.ts
I guess this lib should adapt to use the ones from DS instead of strings.
What do you guys think?

Justification

Otherwise we need to remap types:
initialize({
region: 'CH',
language: LanguagesOfSwitzerland.valueOfOrDefault(
getBrowserLang() ?? GERMAN.key,
).key as BalSwissLanguage,
allowedLanguages: LanguagesOfSwitzerland.all.map(
(lan) => lan.key as BalSwissLanguage,
),
});

@nobilo nobilo added the enhancement New feature or request label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant