New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find deputy codeowner for "baloise/rocket-chat-rest-client" #34

Open

MarkusTiede opened this issue Sep 5, 2019 · 5 comments

Assignees

Member

MarkusTiede commented Sep 5, 2019 •

edited

Loading

https://github.com/baloise/rocket-chat-rest-client/blob/master/docs/CODEOWNERS

Member Author

MarkusTiede commented Oct 10, 2019

#37 partially addressed this.

MarkusTiede assigned culmat

Member Author

MarkusTiede commented Oct 10, 2019 •

edited

Loading

@culmat : Do you think this is sufficient? IMHO: Yes.

Collaborator

col-panic commented Oct 10, 2019

Seems like https://github.community/t5/How-to-use-Git-and-GitHub/Do-not-require-owner-approval-if-the-pull-request-is-from-an/td-p/1331/page/4 blocks me from approving my own PRs ....

Member Author

MarkusTiede commented Oct 10, 2019

@col-panic - could you re-check? I've disabled the review requirement for master branch protection for now:

Collaborator

col-panic commented Oct 10, 2019

works now! thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment