Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.yaml #69

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Update config.yaml #69

merged 1 commit into from
Jun 30, 2023

Conversation

culmat
Copy link
Member

@culmat culmat commented Jun 28, 2023

Set base permissions for all members to write

@culmat
Update config.yaml
6bba40c 
Set base permissions for all members to *write*
@culmat culmat requested a review from a team as a code owner June 28, 2023 14:47
kullmanp
kullmanp approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@kullmanp kullmanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already restrict access to the group -- why should we disallow write access in addition?
Let's be open by default and restrict write access only in the rare cases where this would be needed.

@kullmanp kullmanp merged commit 0b7de05 into main Jun 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kullmanp kullmanp kullmanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@culmat @kullmanp