Use pathlib.Path for path functionality #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiansiegel
approved these changes
Nov 19, 2023
| @@ -35,7 +35,7 @@ def finalize(self) -> None: | |||
|
|
|||
| def get_full_file_path(self, relative_path: str) -> str: | |||
| repo = self.__get_repo() | |||
| return os.path.join(str(repo.working_dir), relative_path) | |||
| return str(Path(repo.working_dir) / relative_path) | |||
There was a problem hiding this comment.
Could directly return Path object here. It's re-wrapped everywhere anyways
| if preview_env_already_exist: | ||
| logging.info("Use existing folder for preview: %s", preview_namespace) | ||
| return False | ||
| logging.info("Create new folder for preview: %s", preview_namespace) | ||
| full_preview_template_folder_path = template_git_repo.get_full_file_path(gitops_config.preview_template_path) | ||
| if not os.path.isdir(full_preview_template_folder_path): | ||
| if not Path(full_preview_template_folder_path).is_dir(): |
There was a problem hiding this comment.
I wonder if we could extract those checks into a separate dependency to prevent the need to continue to do this ugly monkey patching. Something like path_checker.is_dir(full_preview_template_folder_path)
|
🎉 This issue has been resolved in version 5.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the last part of dedicated file based rule exclusion from the migration to ruff.
It might be a good idea to use Path class in a future patch more consistently throughout the code.