Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on PyPI #139

Closed
janbrohl opened this issue Dec 15, 2020 · 5 comments
Closed

Release on PyPI #139

janbrohl opened this issue Dec 15, 2020 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@janbrohl
Copy link

As this package already is installable via pip, semver-versioned >=1.0.0, open source licensed - why not release on PyPI?

@janbrohl janbrohl added the enhancement New feature or request label Dec 15, 2020
@christiansiegel
Copy link
Member

For us that was not a high priority yet as we only use the docker image.

Some things we might look into before releasing on PyPI:

  • support and tests for more than one python version (currently only 3.8 is used in the docker build/test; I think even 3.7 doesn't work at the moment)
  • support windows (currently the temporary directory for git checkout is hardcoded to /tmp)
  • add proper error message if there is no git installed (currently probably results in an ugly exception)

All of those improvements would also benefit #104.

@christiansiegel christiansiegel added the help wanted Extra attention is needed label Dec 15, 2020
@janbrohl
Copy link
Author

Currently the Setup Page does not indicate any specific prerequisites for installing from source - would this be a new issue?

@christiansiegel
Copy link
Member

Currently the Setup Page does not indicate any specific prerequisites for installing from source - would this be a new issue?

Definetely an overlap, but I'd create a new one for now 😉

@janbrohl
Copy link
Author

For the /tmp problem, the tempfile module should help.

@christiansiegel
Copy link
Member

Closing. I don't think this is anything we'll focus on any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants