diff --git a/.changeset/quiet-timers-rest.md b/.changeset/quiet-timers-rest.md new file mode 100644 index 000000000..bf945a372 --- /dev/null +++ b/.changeset/quiet-timers-rest.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**footer**: make language selection in footer consistent (#1388) diff --git a/.gitignore b/.gitignore index eda39f308..a2207cc92 100644 --- a/.gitignore +++ b/.gitignore @@ -37,6 +37,7 @@ npm-debug.log yarn-error.log testem.log /typings +.npmrc # System Files .DS_Store diff --git a/packages/core/src/components/bal-footer/bal-footer.sass b/packages/core/src/components/bal-footer/bal-footer.sass index 64b5c7e51..e606d3fb4 100644 --- a/packages/core/src/components/bal-footer/bal-footer.sass +++ b/packages/core/src/components/bal-footer/bal-footer.sass @@ -47,6 +47,9 @@ flex-wrap: nowrap align-items: center + bal-icon, .input + cursor: pointer + &:hover bal-icon +fillSvg(var(--bal-footer-language-background-hover)) diff --git a/packages/core/src/components/bal-footer/bal-footer.tsx b/packages/core/src/components/bal-footer/bal-footer.tsx index 34ed5979d..d0f7e08c1 100644 --- a/packages/core/src/components/bal-footer/bal-footer.tsx +++ b/packages/core/src/components/bal-footer/bal-footer.tsx @@ -12,12 +12,15 @@ import { import { BEM } from '../../utils/bem' import { Loggable, Logger, LogInstance } from '../../utils/log' import { rIC } from '../../utils/helpers' +import { stopEventBubbling } from '../../utils/form-input' @Component({ tag: 'bal-footer', styleUrl: 'bal-footer.sass', }) export class Footer implements BalConfigObserver, Loggable { + private selectEl: HTMLBalSelectElement | undefined + @State() links: FooterLink[] = [] @State() socialMediaLinks: SocialMediaLink[] = [] @State() language: BalLanguage = defaultConfig.language @@ -179,8 +182,13 @@ export class Footer implements BalConfigObserver, Loggable { }} name="web" color="white" + onClick={el => { + stopEventBubbling(el) + this.selectEl?.open() + }} > (this.selectEl = el as HTMLBalSelectElement)} value={this.language} onBalChange={event => this.changeLanguage(event.detail as any)} data-testid="bal-footer-language"