From 957014461351adb0ddddd896de53d44a6f6fb431 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 6 Sep 2024 11:13:44 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BF=20a11y(bal-nav):=20button=20overlays?= =?UTF-8?q?=20not=20reachable=20via=20keyboard=20(#1438)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Create PR for #1415 * fix(close): make close button focusable by changing tabindex from -1 to 0 * fix(close): make close button focusable by changing tabindex from -1 to 0 * chore: add changeset * chore: add changeset --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Marinkov, Magdalena Co-authored-by: Gery Hirschfeld --- .changeset/wet-cycles-report.md | 5 +++++ packages/core/src/components/bal-close/bal-close.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/wet-cycles-report.md diff --git a/.changeset/wet-cycles-report.md b/.changeset/wet-cycles-report.md new file mode 100644 index 000000000..36fe96875 --- /dev/null +++ b/.changeset/wet-cycles-report.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**close**: is accessible by the keyboard diff --git a/packages/core/src/components/bal-close/bal-close.tsx b/packages/core/src/components/bal-close/bal-close.tsx index ea8fb9ebd..4f2418288 100644 --- a/packages/core/src/components/bal-close/bal-close.tsx +++ b/packages/core/src/components/bal-close/bal-close.tsx @@ -53,7 +53,7 @@ export class Close implements ComponentInterface, BalConfigObserver { type="button" aria-label={label} title={label} - tabindex={-1} + tabindex="0" class={{ ...buttonEl.class(), ...buttonEl.modifier('inverted').class(this.inverted),