From 5d661b5801ff23661a7d346ca0335c9b1be1db3d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 16 May 2024 15:13:07 +0200 Subject: [PATCH] :bug: fix(bal-modal): opening bal-modal leads to page scroll to top (#1398) * Create PR for #1396 * fix(modal): keep scroll position --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gery Hirschfeld --- .changeset/fuzzy-scissors-peel.md | 5 +++++ packages/core/src/utils/scroll.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fuzzy-scissors-peel.md diff --git a/.changeset/fuzzy-scissors-peel.md b/.changeset/fuzzy-scissors-peel.md new file mode 100644 index 0000000000..9b4a5d2b8d --- /dev/null +++ b/.changeset/fuzzy-scissors-peel.md @@ -0,0 +1,5 @@ +--- +'@baloise/ds-core': patch +--- + +**modal**: will keep scroll postition diff --git a/packages/core/src/utils/scroll.ts b/packages/core/src/utils/scroll.ts index 3211983846..8a0ec01522 100644 --- a/packages/core/src/utils/scroll.ts +++ b/packages/core/src/utils/scroll.ts @@ -69,7 +69,7 @@ export class BalScrollHandler { } disable() { - if (this.target) { + if (!this.disabled && this.target) { if (balBrowser.hasWindow && balBrowser.hasDocument) { this.x = window.pageXOffset || document.documentElement.scrollLeft this.y = window.pageYOffset || document.documentElement.scrollTop