Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to deploy6 #60

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Update to deploy6 #60

merged 6 commits into from
Jul 15, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Jul 12, 2024 •
edited
Loading

Closes #57

Backend

  • Minor updates to hooks contract and LiquidityManagement to match deploy6
  • Adjusted pool deploy scripts to be initialized with 50 of each mock token instead of just 10
  • v3 monorepo dep was coming from branch installed in node_modules, but changed to using git submodule installed in foundry/lib using
forge install https://github.com/balancer/balancer-v3-monorepo@d048af4

Frontend

  • Updated to SDK v0.20.0 including change from vaultVersion to protocolVersion
  • Using contract names for the pool selector buttons on pools page ( instead of abbreviated addresses )

@MattPereira MattPereira marked this pull request as ready for review July 14, 2024 18:45
@vercel Vercel
Copy link

vercel bot commented Jul 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffold-balancer-v3 ❌ Failed (Inspect) Jul 14, 2024 7:02pm

@MattPereira
Copy link
Member Author

MattPereira commented Jul 14, 2024 •
edited
Loading

Vercel should'nt be trying to deploy this PR branch into main
Will fix it so it only deploys branches that are intended for production

johngrantuk
johngrantuk reviewed Jul 15, 2024
View reviewed changes
packages/nextjs/public/thumbnail.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen this before - nice!

johngrantuk
johngrantuk approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with forge install!

@MattPereira MattPereira merged commit f481976 into main Jul 15, 2024
2 of 3 checks passed
@MattPereira MattPereira deleted the update-to-deploy6 branch July 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrantuk johngrantuk johngrantuk approved these changes

@brunoguerios brunoguerios Awaiting requested review from brunoguerios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to deploy6
2 participants
@MattPereira @johngrantuk