Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inception Arbitrum Rate Providers - inETH & instETH #91

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

mkflow27
Copy link
Collaborator

Fixes #74

@mkflow27
Copy link
Collaborator Author

mkflow27 commented Jun 24, 2024

@Zen-Maxi The rate provider now should work well with Balancer pools. An additional suggestion would be to also implement further validity checks if the rate gets repaired.

@mkflow27 mkflow27 requested a review from danielmkm June 26, 2024 08:56
Zen-Maxi added a commit to BalancerMaxis/multisig-ops that referenced this pull request Jun 27, 2024
Zen-Maxi added a commit to BalancerMaxis/multisig-ops that referenced this pull request Jun 27, 2024
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkflow27, looks good. Would echo the comment above, the ability for a 3/5 to arbitrarily set the rate is concerning.

Copy link
Collaborator

@Zen-Maxi Zen-Maxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want the registry to say safe instead of unsafe @mkflow27 ?

@mkflow27 mkflow27 merged commit 0c1e0d2 into main Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inception Arbitrum Rate Providers - inETH & instETH
3 participants