Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balETH ERC4626 Rate Provider #152

Merged
merged 3 commits into from
Sep 19, 2024
Merged

balETH ERC4626 Rate Provider #152

merged 3 commits into from
Sep 19, 2024

Conversation

mkflow27
Copy link
Collaborator

@mkflow27 mkflow27 commented Sep 18, 2024 •
edited by danielmkm
Loading

Fixes #148

Outstanding activities:

  • peer review
  • schedule more thorough review once pool gains more traction.

danielmkm
danielmkm approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rate provider here is fine, but I would echo @mkflow27, the underlying system is extremely complex and we just scratched the surface in this review. A more in depth review would be highly beneficial at a later point.

@mkflow27 mkflow27 merged commit fa23a97 into main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmkm danielmkm danielmkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

balETH ERC4626 Rate Provider
2 participants
@mkflow27 @danielmkm