From 10477b75a8e98419e6828f811c7188fd75b83286 Mon Sep 17 00:00:00 2001 From: mkflow27 <35266877+mkflow27@users.noreply.github.com> Date: Wed, 5 Jun 2024 11:07:14 +0200 Subject: [PATCH 1/8] rETH/ETH rate provider Fixes #73 --- rate-providers/rETHRateProviderGnosis.md | 64 ++++++++++++++++++++++++ rate-providers/registry.json | 9 ++++ 2 files changed, 73 insertions(+) create mode 100644 rate-providers/rETHRateProviderGnosis.md diff --git a/rate-providers/rETHRateProviderGnosis.md b/rate-providers/rETHRateProviderGnosis.md new file mode 100644 index 0000000..0c38e30 --- /dev/null +++ b/rate-providers/rETHRateProviderGnosis.md @@ -0,0 +1,64 @@ +# Rate Provider: `TollgateChronicleRateProvider` + +## Details +- Reviewed by: @mkflow27 +- Checked by: @\ +- Deployed at: + - [gnosis:0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD](https://gnosisscan.io/address/0xdc90e2680094314ceab45ce15100f6e02ceb7ced#code) +- Audit report(s): + - [Chronicle Oracles audits](\) + +## Context +This rate Provider bridges the eth/reth exchange rate from Mainnet to gnosis chain. This is done via an oracle solution developed by chronicle. + +## Review Checklist: Bare Minimum Compatibility +Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. + +- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. +- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. + +## Review Checklist: Common Findings +Each of the items below represents a common red flag found in Rate Provider contracts. + +If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. + +### Administrative Privileges +- [ ] The Rate Provider is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). + +- [ ] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). + +### Oracles +- [x] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). + - source: Chronicle protocol Oracle + - source address: [gnosis:0xE04a8f725b49c9D36C0fD3495F4a792056374847](https://gnosisscan.io/address/0xe04a8f725b49c9d36c0fd3495f4a792056374847) + - any protections? YES + - The rate data's supplied age must be greater than the timestamp of last successful update + - the rate data's age must not be greater than current time + - The rate data's integrity is verified by the supplied signature. Currently `bar` (7) signers verify the rate's integrity. For more information see `_poke` and `isAcceptableSchnorrSignatureNow` as part of the PriceFeed `Chronicle_RETH_ETH_1` contract deployed at [gnosis:0x7706A143c750aDfc2196c4Bf84e6BB012Aed1182](https://gnosisscan.io/address/0x7706a143c750adfc2196c4bf84e6bb012aed1182#code) + +- [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). + +### Common Manipulation Vectors +- [ ] The Rate Provider is susceptible to donation attacks. + +## Additional Findings +To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. + +### M-01: `owner` is an EOA and can make Rate Provider revert. +The current `owner` of the RateProvider can call `enableTollgate` which would in its current form make the RateProvider revert. +```solidity +function getRate() public view override returns (uint256) { +if (tollgateEnabled && !tolled(msg.sender)) { + revert NotTolled(msg.sender); +} + +return super.getRate(); +} +``` +Currently `tollgateEnabled` is false and the msg.sender (the pool) is not tolled, skipping the if condition. However if the tollgate was enabled, the rateProvider would revert. Currently the `owner` has this capability. + +Suggestion: The `owner` should call `transferOwnership` with the `newOwner` being a multisig. + +## Conclusion +**Summary judgment: \** + diff --git a/rate-providers/registry.json b/rate-providers/registry.json index 58284ef..793e937 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1092,6 +1092,15 @@ "implementationReviewed": "0x5b522140fabeB6b6232336295581e63902e9b4ad" } ] + }, + "0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD": { + "asset": "", + "name": "TollgateChronicleRateProvider", + "summary": "", + "review": "./rETHRateProviderGnosis.md", + "warnings": [], + "factory": "", + "upgradeableComponents": [] } }, "optimism": { From 356e2ac89a8f325fe35598adfd603323530a9dbb Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 5 Jun 2024 16:05:25 +0200 Subject: [PATCH 2/8] review: add registry --- rate-providers/registry.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rate-providers/registry.json b/rate-providers/registry.json index 793e937..e1c59c2 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1094,7 +1094,7 @@ ] }, "0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD": { - "asset": "", + "asset": "0xc791240d1f2def5938e2031364ff4ed887133c3d", "name": "TollgateChronicleRateProvider", "summary": "", "review": "./rETHRateProviderGnosis.md", From e7c08578a0d1a0315805d3d27fdadad69a70c333 Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Mon, 10 Jun 2024 17:08:43 +0200 Subject: [PATCH 3/8] review: add GBP & registry update --- ...is.md => TollgateChronicleRateProvider.md} | 40 +++++++++---------- rate-providers/registry.json | 11 ++++- 2 files changed, 28 insertions(+), 23 deletions(-) rename rate-providers/{rETHRateProviderGnosis.md => TollgateChronicleRateProvider.md} (51%) diff --git a/rate-providers/rETHRateProviderGnosis.md b/rate-providers/TollgateChronicleRateProvider.md similarity index 51% rename from rate-providers/rETHRateProviderGnosis.md rename to rate-providers/TollgateChronicleRateProvider.md index 0c38e30..b84bac7 100644 --- a/rate-providers/rETHRateProviderGnosis.md +++ b/rate-providers/TollgateChronicleRateProvider.md @@ -5,11 +5,12 @@ - Checked by: @\ - Deployed at: - [gnosis:0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD](https://gnosisscan.io/address/0xdc90e2680094314ceab45ce15100f6e02ceb7ced#code) + - [gnosis:0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33](https://gnosisscan.io/address/0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33#code) - Audit report(s): - [Chronicle Oracles audits](\) ## Context -This rate Provider bridges the eth/reth exchange rate from Mainnet to gnosis chain. This is done via an oracle solution developed by chronicle. +This rate Provider bridges the eth/reth exchange rate & GBP/USD to gnosis chain. This is done via an oracle solution developed by chronicle. ## Review Checklist: Bare Minimum Compatibility Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. @@ -29,12 +30,20 @@ If none of these is checked, then this might be a pretty great Rate Provider! If ### Oracles - [x] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). - - source: Chronicle protocol Oracle - - source address: [gnosis:0xE04a8f725b49c9D36C0fD3495F4a792056374847](https://gnosisscan.io/address/0xe04a8f725b49c9d36c0fd3495f4a792056374847) - - any protections? YES - - The rate data's supplied age must be greater than the timestamp of last successful update - - the rate data's age must not be greater than current time - - The rate data's integrity is verified by the supplied signature. Currently `bar` (7) signers verify the rate's integrity. For more information see `_poke` and `isAcceptableSchnorrSignatureNow` as part of the PriceFeed `Chronicle_RETH_ETH_1` contract deployed at [gnosis:0x7706A143c750aDfc2196c4Bf84e6BB012Aed1182](https://gnosisscan.io/address/0x7706a143c750adfc2196c4bf84e6bb012aed1182#code) + - reth/eth: + - source: Chronicle protocol Oracle + - source address: [gnosis:0xE04a8f725b49c9D36C0fD3495F4a792056374847](https://gnosisscan.io/address/0xe04a8f725b49c9d36c0fd3495f4a792056374847) + - any protections? YES + - The rate data's supplied age must be greater than the timestamp of last successful update + - the rate data's age must not be greater than current time + - The rate data's integrity is verified by the supplied signature. Currently `bar` (7) signers verify the rate's integrity. For more information see `_poke` and `isAcceptableSchnorrSignatureNow` as part of the PriceFeed `Chronicle_RETH_ETH_1` contract deployed at [gnosis:0x7706A143c750aDfc2196c4Bf84e6BB012Aed1182](https://gnosisscan.io/address/0x7706a143c750adfc2196c4bf84e6bb012aed1182#code) + - GBP/USD: + - source: Chronicle protocol Oracle + - source address: [gnosis:0x0E418d54863a3fAfeC9e96a358795f0f236f5f66](https://gnosisscan.io/address/0x0E418d54863a3fAfeC9e96a358795f0f236f5f66) + - any protections? YES + - The rate data's supplied age must be greater than the timestamp of last successful update + - the rate data's age must not be greater than current time + - The rate data's integrity is verified by the supplied signature. Currently `bar` (7) signers verify the rate's integrity. For more information see `_poke` and `isAcceptableSchnorrSignatureNow` as part of the PriceFeed `Chronicle_GBP_USD_1` contract deployed at [gnosis:0x0E418d54863a3fAfeC9e96a358795f0f236f5f66](https://gnosisscan.io/address/0x0E418d54863a3fAfeC9e96a358795f0f236f5f66#code) - [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). @@ -44,21 +53,8 @@ If none of these is checked, then this might be a pretty great Rate Provider! If ## Additional Findings To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. -### M-01: `owner` is an EOA and can make Rate Provider revert. -The current `owner` of the RateProvider can call `enableTollgate` which would in its current form make the RateProvider revert. -```solidity -function getRate() public view override returns (uint256) { -if (tollgateEnabled && !tolled(msg.sender)) { - revert NotTolled(msg.sender); -} - -return super.getRate(); -} -``` -Currently `tollgateEnabled` is false and the msg.sender (the pool) is not tolled, skipping the if condition. However if the tollgate was enabled, the rateProvider would revert. Currently the `owner` has this capability. - -Suggestion: The `owner` should call `transferOwnership` with the `newOwner` being a multisig. ## Conclusion -**Summary judgment: \** +**Summary judgment: ** +This rate provider should work well with Balancer pools. The oracle providing the rate data has various guardrails in place ensuring the integrity of the rate being provided. The `owner` of the rate provider has the capability to revert the call to `getRate`. However this potential revert scenario is guarded behind a Multisig of [1/4] for reth and [2/6] for GBP. diff --git a/rate-providers/registry.json b/rate-providers/registry.json index e1c59c2..9748229 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1097,7 +1097,16 @@ "asset": "0xc791240d1f2def5938e2031364ff4ed887133c3d", "name": "TollgateChronicleRateProvider", "summary": "", - "review": "./rETHRateProviderGnosis.md", + "review": "./TollgateChronicleRateProvider.md", + "warnings": [], + "factory": "", + "upgradeableComponents": [] + }, + "0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33": { + "asset": "", + "name": "TollgateChronicleRateProvider", + "summary": "", + "review": "./TollgateChronicleRateProvider.md", "warnings": [], "factory": "", "upgradeableComponents": [] From 78d7c5081c4a591bff716992581f86a3bbc6cbbc Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 12 Jun 2024 08:26:25 +0200 Subject: [PATCH 4/8] rsETH Rate Provider - Arbitrum Fixes #81 --- rate-providers/registry.json | 30 ++++++++ rate-providers/rsETHRateProviderArbitrum.md | 79 +++++++++++++++++++++ 2 files changed, 109 insertions(+) create mode 100644 rate-providers/rsETHRateProviderArbitrum.md diff --git a/rate-providers/registry.json b/rate-providers/registry.json index a224297..e3783da 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -268,6 +268,36 @@ "upgradeableComponents": [] } }, + "0x3222d3De5A9a3aB884751828903044CC4ADC627e": { + "asset": "", + "name": "RsETHRateProvider", + "summary": "safe", + "review": "rsETHRateProvider.md", + "warnings": ["donation"], + "factory": "", + "upgradeableComponents": [ + { + "entrypoint": "0x349A73444b1a310BAe67ef67973022020d70020d", + "implementationReviewed": "0x8B9991f89Fc31600DCE064566ccE28dC174Fb8E4" + }, + { + "entrypoint": "0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7", + "implementationReviewed": "0xc5cD38d47D0c2BD7Fe18c64a50c512063DC29700" + }, + { + "entrypoint": "0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7", + "implementationReviewed": "0x60FF20BACD9A647e4025Ed8b17CE30e40095A1d2" + }, + { + "entrypoint": "0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2", + "implementationReviewed": "0x0379E85188BC416A1D43Ab04b28F38B5c63F129E" + }, + { + "entrypoint": "0x8546A7C8C3C537914C3De24811070334568eF427", + "implementationReviewed": "0xD7DB9604EF925aF96CDa6B45026Be64C691C7704" + } + ] + }, "avalanche": { "0xd6Fd021662B83bb1aAbC2006583A62Ad2Efb8d4A": { "asset": "0x12d8ce035c5de3ce39b1fdd4c1d5a745eaba3b8c", diff --git a/rate-providers/rsETHRateProviderArbitrum.md b/rate-providers/rsETHRateProviderArbitrum.md new file mode 100644 index 0000000..282db21 --- /dev/null +++ b/rate-providers/rsETHRateProviderArbitrum.md @@ -0,0 +1,79 @@ +# Rate Provider: `RSETHRateReceiver` + +## Details +- Reviewed by: @mkflow27 +- Checked by: @ +- Deployed at: + - [arbitrum:0x3222d3De5A9a3aB884751828903044CC4ADC627e](https://arbiscan.io/address/0x3222d3de5a9a3ab884751828903044cc4adc627e#code) +- Audit report(s): + - [Kelp audits](https://kelp.gitbook.io/kelp/audits) + +## Context +rsETH is a Liquid Restaked Token (LRT) issued by Kelp DAO designed to offer liquidity to illiquid assets deposited into restaking platforms, such as EigenLayer. It aims to address the risks and challenges posed by the current offering of restaking. The Rate Provider reports the exchange Rate of rsETH - ETH. + +## Review Checklist: Bare Minimum Compatibility +Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. + +- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. +- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. + +## Review Checklist: Common Findings +Each of the items below represents a common red flag found in Rate Provider contracts. + +If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. + +### Administrative Privileges +- [x] The Rate Provider is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). + - admin address: [arbitrum:0x96D97D66d4290C9182A09470a5775FF90DAf922c](https://arbiscan.io/address/0x96D97D66d4290C9182A09470a5775FF90DAf922c) + - admin type: multisig + - multisig threshold/signers: 2/4 + - comment: The main access control check is done by comparing the `msg.sender` against the `layerZeroEndpoint`. The `layerZeroEndpoint` endpoint address can be upgraded by the RateProviders admin via: `updateLayerZeroEndpoint`. + +- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). +- upgradeable component: `LRTOracle` ([ethereum:0x349A73444b1a310BAe67ef67973022020d70020d](https://etherscan.io/address/0x349A73444b1a310BAe67ef67973022020d70020d)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + +- upgradeable component: `LRTConfig` ([ethereum:0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7](https://etherscan.io/address/0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7#code)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + +- upgradeable component: `RSETH` ([ethereum:0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7](https://etherscan.io/address/0xa1290d69c65a6fe4df752f95823fae25cb99e5a7)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + +- upgradeable component: `EthXPriceOracle` ([ethereum:0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2](https://etherscan.io/address/0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2#readProxyContract)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + +- upgradeable component: `SfrxETHPriceOracle` ([ethereum:0x8546A7C8C3C537914C3De24811070334568eF427](https://etherscan.io/address/0x8546A7C8C3C537914C3De24811070334568eF427#readProxyContract)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + + + +### Oracles +- [ ] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). + +- [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). + +### Common Manipulation Vectors +- [ ] The Rate Provider is susceptible to donation attacks. + + +## Additional Findings +To save time, we do not bother pointing out low-severity/informational issues or gas optimizations (unless the gas usage is particularly egregious). Instead, we focus only on high- and medium-severity findings which materially impact the contract's functionality and could harm users. + +### M-01: Hardcoded stETH price +The rsETH pricing logic loops over the involved assets pricing oracles. This includes the [pricing oracle for stETH](https://etherscan.io/address/0x4cB8d6DCd56d6b371210E70837753F2a835160c4#code). The price of stETH in the Rate Provider pricing system is set to 1e18 which can pose a risk depending on LIDOs operational staking integrity. +Recommendation: Consider replacing the hardcoded value to incorporate for example a stETH/ETH Chainlink price feed. + +## Conclusion +**Summary judgment: SAFE** + +This rate Provider can be considered fit for pool operations under the assumption that the stETH/ETH peg holds at 1:1. This should be made clear to users in the Balancer Pool. From 778b1ac6d65860361202af3b44375b087f1aceb3 Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 12 Jun 2024 10:29:32 +0200 Subject: [PATCH 5/8] review: add asset & audit --- rate-providers/TollgateChronicleRateProvider.md | 6 +++--- rate-providers/registry.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rate-providers/TollgateChronicleRateProvider.md b/rate-providers/TollgateChronicleRateProvider.md index b84bac7..62f02ec 100644 --- a/rate-providers/TollgateChronicleRateProvider.md +++ b/rate-providers/TollgateChronicleRateProvider.md @@ -7,7 +7,7 @@ - [gnosis:0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD](https://gnosisscan.io/address/0xdc90e2680094314ceab45ce15100f6e02ceb7ced#code) - [gnosis:0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33](https://gnosisscan.io/address/0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33#code) - Audit report(s): - - [Chronicle Oracles audits](\) + - [Chronicle audits](https://github.com/chronicleprotocol/scribe/tree/main/audits) ## Context This rate Provider bridges the eth/reth exchange rate & GBP/USD to gnosis chain. This is done via an oracle solution developed by chronicle. @@ -55,6 +55,6 @@ To save time, we do not bother pointing out low-severity/informational issues or ## Conclusion -**Summary judgment: ** +**Summary judgment: SAFE** -This rate provider should work well with Balancer pools. The oracle providing the rate data has various guardrails in place ensuring the integrity of the rate being provided. The `owner` of the rate provider has the capability to revert the call to `getRate`. However this potential revert scenario is guarded behind a Multisig of [1/4] for reth and [2/6] for GBP. +This rate provider should work well with Balancer pools. The oracle providing the rate data has various guardrails in place ensuring the integrity of the rate being provided. The `owner` of the rate provider has the capability to revert the call to `getRate`. However this potential revert scenario is guarded behind a Multisig of [2/6] for reth and [2/6] for GBP. diff --git a/rate-providers/registry.json b/rate-providers/registry.json index 9748229..1e85bbd 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1103,7 +1103,7 @@ "upgradeableComponents": [] }, "0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33": { - "asset": "", + "asset": "0x5Cb9073902F2035222B9749F8fB0c9BFe5527108", "name": "TollgateChronicleRateProvider", "summary": "", "review": "./TollgateChronicleRateProvider.md", From 2361df6180b9681c0b0a45097fe66801a5630e7d Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 12 Jun 2024 10:46:42 +0200 Subject: [PATCH 6/8] rsETH Rate Provider - Arbitrum Fixes #81 --- rate-providers/registry.json | 60 ++++++++++----------- rate-providers/rsETHRateProviderArbitrum.md | 48 ++++++++--------- 2 files changed, 54 insertions(+), 54 deletions(-) diff --git a/rate-providers/registry.json b/rate-providers/registry.json index e3783da..1e93a8e 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -266,38 +266,38 @@ "warnings": ["chainlink"], "factory": "0x5DbAd78818D4c8958EfF2d5b95b28385A22113Cd", "upgradeableComponents": [] + }, + "0x3222d3De5A9a3aB884751828903044CC4ADC627e": { + "asset": "0x4186BFC76E2E237523CBC30FD220FE055156b41F", + "name": "RsETHRateProvider", + "summary": "safe", + "review": "./rsETHRateProviderArbitrum.md", + "warnings": ["donation"], + "factory": "", + "upgradeableComponents": [ + { + "entrypoint": "0x349A73444b1a310BAe67ef67973022020d70020d", + "implementationReviewed": "0x8B9991f89Fc31600DCE064566ccE28dC174Fb8E4" + }, + { + "entrypoint": "0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7", + "implementationReviewed": "0xc5cD38d47D0c2BD7Fe18c64a50c512063DC29700" + }, + { + "entrypoint": "0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7", + "implementationReviewed": "0x60FF20BACD9A647e4025Ed8b17CE30e40095A1d2" + }, + { + "entrypoint": "0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2", + "implementationReviewed": "0x0379E85188BC416A1D43Ab04b28F38B5c63F129E" + }, + { + "entrypoint": "0x8546A7C8C3C537914C3De24811070334568eF427", + "implementationReviewed": "0xD7DB9604EF925aF96CDa6B45026Be64C691C7704" + } + ] } }, - "0x3222d3De5A9a3aB884751828903044CC4ADC627e": { - "asset": "", - "name": "RsETHRateProvider", - "summary": "safe", - "review": "rsETHRateProvider.md", - "warnings": ["donation"], - "factory": "", - "upgradeableComponents": [ - { - "entrypoint": "0x349A73444b1a310BAe67ef67973022020d70020d", - "implementationReviewed": "0x8B9991f89Fc31600DCE064566ccE28dC174Fb8E4" - }, - { - "entrypoint": "0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7", - "implementationReviewed": "0xc5cD38d47D0c2BD7Fe18c64a50c512063DC29700" - }, - { - "entrypoint": "0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7", - "implementationReviewed": "0x60FF20BACD9A647e4025Ed8b17CE30e40095A1d2" - }, - { - "entrypoint": "0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2", - "implementationReviewed": "0x0379E85188BC416A1D43Ab04b28F38B5c63F129E" - }, - { - "entrypoint": "0x8546A7C8C3C537914C3De24811070334568eF427", - "implementationReviewed": "0xD7DB9604EF925aF96CDa6B45026Be64C691C7704" - } - ] - }, "avalanche": { "0xd6Fd021662B83bb1aAbC2006583A62Ad2Efb8d4A": { "asset": "0x12d8ce035c5de3ce39b1fdd4c1d5a745eaba3b8c", diff --git a/rate-providers/rsETHRateProviderArbitrum.md b/rate-providers/rsETHRateProviderArbitrum.md index 282db21..0ed32d5 100644 --- a/rate-providers/rsETHRateProviderArbitrum.md +++ b/rate-providers/rsETHRateProviderArbitrum.md @@ -30,30 +30,30 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - comment: The main access control check is done by comparing the `msg.sender` against the `layerZeroEndpoint`. The `layerZeroEndpoint` endpoint address can be upgraded by the RateProviders admin via: `updateLayerZeroEndpoint`. - [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). -- upgradeable component: `LRTOracle` ([ethereum:0x349A73444b1a310BAe67ef67973022020d70020d](https://etherscan.io/address/0x349A73444b1a310BAe67ef67973022020d70020d)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `LRTConfig` ([ethereum:0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7](https://etherscan.io/address/0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7#code)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `RSETH` ([ethereum:0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7](https://etherscan.io/address/0xa1290d69c65a6fe4df752f95823fae25cb99e5a7)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `EthXPriceOracle` ([ethereum:0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2](https://etherscan.io/address/0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 - -- upgradeable component: `SfrxETHPriceOracle` ([ethereum:0x8546A7C8C3C537914C3De24811070334568eF427](https://etherscan.io/address/0x8546A7C8C3C537914C3De24811070334568eF427#readProxyContract)) - - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) - - admin type: multisig - - multisig threshold/signers: 3/5 + - upgradeable component: `LRTOracle` ([ethereum:0x349A73444b1a310BAe67ef67973022020d70020d](https://etherscan.io/address/0x349A73444b1a310BAe67ef67973022020d70020d)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + + - upgradeable component: `LRTConfig` ([ethereum:0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7](https://etherscan.io/address/0x947Cb49334e6571ccBFEF1f1f1178d8469D65ec7#code)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + + - upgradeable component: `RSETH` ([ethereum:0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7](https://etherscan.io/address/0xa1290d69c65a6fe4df752f95823fae25cb99e5a7)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + + - upgradeable component: `EthXPriceOracle` ([ethereum:0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2](https://etherscan.io/address/0x3D08ccb47ccCde84755924ED6B0642F9aB30dFd2#readProxyContract)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 + + - upgradeable component: `SfrxETHPriceOracle` ([ethereum:0x8546A7C8C3C537914C3De24811070334568eF427](https://etherscan.io/address/0x8546A7C8C3C537914C3De24811070334568eF427#readProxyContract)) + - admin address: [ethereum:0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2](https://etherscan.io/address/0xb9577E83a6d9A6DE35047aa066E3758221FE0DA2) + - admin type: multisig + - multisig threshold/signers: 3/5 From 769d20872119b59e0486251ecf6613b5345819c5 Mon Sep 17 00:00:00 2001 From: Daniel Date: Wed, 12 Jun 2024 15:43:44 -0600 Subject: [PATCH 7/8] add checked by --- rate-providers/rsETHRateProviderArbitrum.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rate-providers/rsETHRateProviderArbitrum.md b/rate-providers/rsETHRateProviderArbitrum.md index 0ed32d5..14c8334 100644 --- a/rate-providers/rsETHRateProviderArbitrum.md +++ b/rate-providers/rsETHRateProviderArbitrum.md @@ -2,7 +2,7 @@ ## Details - Reviewed by: @mkflow27 -- Checked by: @ +- Checked by: @danielmkm - Deployed at: - [arbitrum:0x3222d3De5A9a3aB884751828903044CC4ADC627e](https://arbiscan.io/address/0x3222d3de5a9a3ab884751828903044cc4adc627e#code) - Audit report(s): From 592f7ece01c23a69a27a20cb8b9c9a3130c46f60 Mon Sep 17 00:00:00 2001 From: Daniel Date: Tue, 18 Jun 2024 09:20:49 -0600 Subject: [PATCH 8/8] Add checked by --- rate-providers/TollgateChronicleRateProvider.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rate-providers/TollgateChronicleRateProvider.md b/rate-providers/TollgateChronicleRateProvider.md index 62f02ec..aecef98 100644 --- a/rate-providers/TollgateChronicleRateProvider.md +++ b/rate-providers/TollgateChronicleRateProvider.md @@ -2,7 +2,7 @@ ## Details - Reviewed by: @mkflow27 -- Checked by: @\ +- Checked by: @danielmkm - Deployed at: - [gnosis:0xdc90e2680094314CEaB45CE15100F6e02cEB7ceD](https://gnosisscan.io/address/0xdc90e2680094314ceab45ce15100f6e02ceb7ced#code) - [gnosis:0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33](https://gnosisscan.io/address/0x92320D3C8Fd6BE59b22eB0eEe330901Fe4617f33#code)