Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using sfx command while another sfx is playing replaces current one #1

Open
Jackenmen opened this issue Mar 23, 2019 · 1 comment
Open
Labels
enhancement sfx Anything related to the sfx cog

Comments

@Jackenmen
Copy link

Hi,
first of all thanks for making sfx happen on Red V3, it was the most important thing for me, before I could migrate from V2.

However, behavior of this sfx is different than flapjax's one for V2 - if you use sfx command while bot plays another sfx, it will replace that sfx with new one instead of just appending it as next one to play. You may want to keep it that way, but it would be nice to have option to append another sfx to queue instead of replacing the currently playing one. This would be useful for creating "combos" or whatever you want to call them 😄

@baiumbg
Copy link
Owner

baiumbg commented Mar 23, 2019

Hi and thanks for trying my version out.
You are correct that it differs a bit from flapjax' implementation - this is the current intended behavior. I've thought about having them queue one after another, but I ended up going with replacement.
I guess I can add a command that toggles between the two behaviors - I'll do that whenever I have some spare time 🙂

@baiumbg baiumbg added the sfx Anything related to the sfx cog label Aug 21, 2019
Jackenmen added a commit to Jackenmen/baiumbg-Cogs that referenced this issue Jul 13, 2022
Jackenmen added a commit to Jackenmen/baiumbg-Cogs that referenced this issue Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement sfx Anything related to the sfx cog
Projects
None yet
Development

No branches or pull requests

2 participants