Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgradeAddress does not support requester authenication #3410

Closed
frrist opened this issue Feb 5, 2024 · 2 comments
Closed

upgradeAddress does not support requester authenication #3410

frrist opened this issue Feb 5, 2024 · 2 comments
Assignees
Labels
type/bug Type: Something is not working as expected

Comments

@frrist
Copy link
Member

frrist commented Feb 5, 2024

When setting up a compute node, you can specify an HTTP multiaddress instead of a P2P multiaddress. In this case, the compute node initiates an HTTP connection to the requester to fetch the peer ID by accessing the endpoint api/v1/agent/node. Using this peer ID, the compute node then constructs a P2P address for the connection. The process of converting an HTTP address to a P2P address is managed by the upgradeAddress method. However, this method currently doesn't include the necessary authentication headers, leading to connection failures with requester nodes that demand authentication.

@frrist frrist added the type/bug Type: Something is not working as expected label Feb 5, 2024
@frrist frrist self-assigned this Feb 5, 2024
@frrist
Copy link
Member Author

frrist commented Feb 5, 2024

As we move away from libp2p this will become a non-issue as NATs doesn't have requirements around public keys in connection strings.

@frrist
Copy link
Member Author

frrist commented Feb 9, 2024

This issue has been mitigated by opting to deploy NATS networks (see #3089). Since we are adopting NATs this will be unneeded.

@frrist frrist closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: Something is not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant