Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor consumer controller interface to take a ctx as parameter #491

Open
bap2pecs opened this issue Jul 8, 2024 · 1 comment
Open

Comments

@bap2pecs
Copy link
Collaborator

bap2pecs commented Jul 8, 2024

#484 (comment)

Using a new background ctx is good for now. What do you think about letting all functions under cc to take a ctx as parameter, such that the main finality program daemon can use its own ctx for all queries in cc. This will let all the queries to share the same ctx, streamlining the scheduling of all Go routines

@bap2pecs
Copy link
Collaborator Author

this might fix this error:

2024-07-09T21:05:59.425-0400	INFO	service/fp_instance.go:178	the finality-provider instance is successfully stopped	{"pk": "fce530fd36cee6291c1c89918f68bf569de253e34b59b0f83925367f0154ff85"}
2024-07-09T21:05:59.425-0400	DEBUG	service/app.go:325	Stopping EOTS manager
2024-07-09T21:05:59.425-0400	DEBUG	service/app.go:331	FinalityProviderApp successfully stopped
    state.go:508:               ERROR[07-09|21:06:00.023] Derivation process error                 role=verifier err="context canceled"
--- PASS: TestOpMultipleFinalityProviders (118.23s)
PASS
ok  	github.com/babylonchain/finality-provider/itest/opstackl2	119.790s

cc @lesterli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant