Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when using different agents (d8, newer node versions) #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meetesh06
Copy link

Note: [This does not affect the current node backend, I just stumbled upon it when changing the backend to d8]

The spawned processes by evalScript may fail to to pass the flags needed to indicate module code. This change might be relevant if the backend is changed/updated in the future.

Before

TAP version 13
# Using 128 threads.
SPAWNED PROCESS CMD:  /home/meetesh/wd/babel-test262-runner/engine/node/bin/node [
  '--expose-gc', 
   '/tmp/lzeQCNpKeVbOkPsgz3xc/eval-export-gen-semi.js' 
] { detached: true }
SPAWNED PROCESS CMD:  /home/meetesh/wd/babel-test262-runner/engine/node/bin/node [
  '--expose-gc',
  '/tmp/R9oDTzDfXLcEkFIpEJWY/eval-export-gen-semi.js' 
] { detached: true }
ok 1 test/language/module-code/eval-export-gen-semi.js strict mode # (success)
ok 2 test/language/module-code/eval-export-gen-semi.js default # (success)
# 
# 
# 
# Run 2 out of 44598 tests.
# Passed 2 out of 2 tests.

After

TAP version 13
# Using 128 threads.
SPAWNED PROCESS CMD:  /home/meetesh/wd/babel-test262-runner/engine/node/bin/node [
  '--experimental-modules', // <-- Missed Earlier
  '--expose-gc',
  '/tmp/4X5ib3ZucDotcJYRrhYJ/eval-export-gen-semi.js'
] { detached: true }
SPAWNED PROCESS CMD:  /home/meetesh/wd/babel-test262-runner/engine/node/bin/node [
  '--experimental-modules', // <-- Missed Earlier
  '--expose-gc',
  '/tmp/jdi2NMnBjIunpcrU39es/eval-export-gen-semi.js'
] { detached: true }
ok 1 test/language/module-code/eval-export-gen-semi.js default # (success)
ok 2 test/language/module-code/eval-export-gen-semi.js strict mode # (success)
# 
# 
# 
# Run 2 out of 44598 tests.
# Passed 2 out of 2 tests.

…s when options are not specified on some agents. (--module flag is missed when using d8 agent and test262-stream test record)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant