Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btc address to eth address #66

Merged
merged 3 commits into from
Dec 7, 2023
Merged

btc address to eth address #66

merged 3 commits into from
Dec 7, 2023

Conversation

oxf71
Copy link
Collaborator

@oxf71 oxf71 commented Nov 30, 2023

Closes: #65

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@oxf71 oxf71 self-assigned this Nov 30, 2023
@oxf71 oxf71 marked this pull request as ready for review December 1, 2023 09:12
0x677261706562616261
0x677261706562616261 reviewed Dec 4, 2023
View reviewed changes
bitcoin/config_test.go
@@ -42,6 +44,8 @@ func TestConfig(t *testing.T) {
require.Equal(t, "", config.Bridge.EthPrivKey)
require.Equal(t, "abi.json", config.Bridge.ABI)
require.Equal(t, uint64(3000), config.Bridge.GasLimit)
require.Equal(t, "0xB457BF68D71a17Fa5030269Fb895e29e6cD2DFF3", config.Bridge.AASCARegistry)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this only for testing?

@0x677261706562616261 0x677261706562616261 merged commit e7d3fe4 into b2network:main Dec 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x677261706562616261 0x677261706562616261 0x677261706562616261 left review comments

Assignees

@oxf71 oxf71

Labels
None yet
Projects
b2network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bridge aa
2 participants
@oxf71 @0x677261706562616261