Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse bitcoin tx #44

Merged
merged 15 commits into from
Nov 22, 2023
Merged

parse bitcoin tx #44

merged 15 commits into from
Nov 22, 2023

Conversation

oxf71
Copy link
Collaborator

@oxf71 oxf71 commented Nov 18, 2023

Closes: #40

Description

#40 (comment)

  • add BITCOINTxIndexer interface

  • add parse block and tx logic

  • add proto file bitcoin_indexer.proto

  • bitcoin_indexer proto add BitcoinTxParseResult message

test wait commiter finished, after use Integration testing


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* add BITCOINTxIndexer interface
* add parse block and tx logic
* add proto file bitcoin_indexer.proto
* bitcoin_indexer proto add BitcoinTxParseResult message
@oxf71 oxf71 marked this pull request as draft November 18, 2023 03:01
@oxf71 oxf71 marked this pull request as ready for review November 18, 2023 07:11
@oxf71 oxf71 added the feature new function label Nov 19, 2023
@0x677261706562616261
Copy link

@oxf71 can you add a basic test for parse method?

@oxf71
Copy link
Collaborator Author

oxf71 commented Nov 21, 2023

@0x677261706562616261 some tests were added, others were added later

@0x677261706562616261 0x677261706562616261 merged commit f95f166 into b2network:main Nov 22, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

parse bitcoin transaction data
2 participants