Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-commiter #30

Merged
merged 6 commits into from
Nov 13, 2023
Merged

init-commiter #30

merged 6 commits into from
Nov 13, 2023

Conversation

zhouop0
Copy link
Collaborator

@zhouop0 zhouop0 commented Nov 13, 2023

Closes: #26

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zhouop0 zhouop0 changed the title format init-commiter Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #30 (7812311) into main (1087db7) will decrease coverage by 0.48%.
The diff coverage is 31.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   68.40%   67.93%   -0.48%     
==========================================
  Files         128      139      +11     
  Lines       10822    10962     +140     
==========================================
+ Hits         7403     7447      +44     
- Misses       2996     3091      +95     
- Partials      423      424       +1     
Files Coverage Δ
x/bitcoincommiter/genesis.go 100.00% <100.00%> (ø)
x/bitcoincommiter/keeper/params.go 100.00% <100.00%> (ø)
x/bitcoincommiter/types/genesis.go 100.00% <100.00%> (ø)
x/bitcoincommiter/keeper/keeper.go 84.61% <84.61%> (ø)
x/bitcoincommiter/keeper/msg_server.go 0.00% <0.00%> (ø)
x/bitcoincommiter/types/keys.go 0.00% <0.00%> (ø)
x/bitcoincommiter/keeper/query_params.go 57.14% <57.14%> (ø)
x/bitcoincommiter/types/codec.go 0.00% <0.00%> (ø)
x/bitcoincommiter/types/params.go 40.00% <40.00%> (ø)
x/bitcoincommiter/module_simulation.go 0.00% <0.00%> (ø)
... and 1 more

@0x677261706562616261 0x677261706562616261 merged commit 026ebb7 into b2network:main Nov 13, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init bitcion-commiter module
2 participants