Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge module #106

Closed
wants to merge 39 commits into from
Closed

Bridge module #106

wants to merge 39 commits into from

Conversation

YuexingZeng
Copy link
Collaborator

Add bridge module.

Copy link

coderabbitai bot commented Jan 19, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

x/bridge/module_simulation.go Fixed Show fixed Hide fixed
package simulation

import (
"math/rand"

Check warning

Code scanning / Semgrep

Semgrep Finding: go.lang.security.audit.crypto.math_random.math-random-used Warning

Do not use math/rand. Use crypto/rand instead.
package simulation

import (
"math/rand"

Check warning

Code scanning / Semgrep

Semgrep Finding: go.lang.security.audit.crypto.math_random.math-random-used Warning

Do not use math/rand. Use crypto/rand instead.
package simulation

import (
"math/rand"

Check warning

Code scanning / Semgrep

Semgrep Finding: go.lang.security.audit.crypto.math_random.math-random-used Warning

Do not use math/rand. Use crypto/rand instead.
package simulation

import (
"math/rand"

Check warning

Code scanning / Semgrep

Semgrep Finding: go.lang.security.audit.crypto.math_random.math-random-used Warning

Do not use math/rand. Use crypto/rand instead.
x/bridge/client/cli/tx.go Fixed Show fixed Hide fixed
x/bridge/module_simulation.go Fixed Show fixed Hide fixed

// String implements the Stringer interface.
func (p Params) String() string {
out, _ := yaml.Marshal(p)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.
x/bridge/module.go Fixed Show fixed Hide fixed
package nullify

import (
"reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note test

Certain system packages contain functions which may be a possible source of non-determinism

import (
"reflect"
"unsafe"

Check notice

Code scanning / CodeQL

Sensitive package import Note test

Certain system packages contain functions which may be a possible source of non-determinism
Comment on lines 206 to 222
for k := range m.Signatures {
v := m.Signatures[k]
baseI := i
i -= len(v)
copy(dAtA[i:], v)
i = encodeVarintWithdraw(dAtA, i, uint64(len(v)))
i--
dAtA[i] = 0x12
i -= len(k)
copy(dAtA[i:], k)
i = encodeVarintWithdraw(dAtA, i, uint64(len(k)))
i--
dAtA[i] = 0xa
i = encodeVarintWithdraw(dAtA, i, uint64(baseI-i))
i--
dAtA[i] = 0x42
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +319 to +324
for k, v := range m.Signatures {
_ = k
_ = v
mapEntrySize := 1 + len(k) + sovWithdraw(uint64(len(k))) + 1 + len(v) + sovWithdraw(uint64(len(v)))
n += mapEntrySize + 1 + sovWithdraw(uint64(mapEntrySize))
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Copy link
Collaborator

@threewebcode threewebcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code changes

Copy link
Collaborator

@threewebcode threewebcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement.

x/bridge/keeper/query_withdraw.go Fixed Show fixed Hide fixed
x/bridge/keeper/query_withdraw.go Fixed Show fixed Hide fixed
Copy link
Collaborator

@threewebcode threewebcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@Stonepapa Stonepapa deleted the branch dev February 26, 2024 06:48
@Stonepapa Stonepapa closed this Feb 26, 2024
@Stonepapa Stonepapa deleted the bridge branch February 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants