Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS settings moved to Client class #27

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

TLS settings moved to Client class #27

wants to merge 6 commits into from

Conversation

skob
Copy link

@skob skob commented Jan 12, 2017

Hi
In some cases we need to create subclasses and create tls (or not tls) connection from children

@b20n
Copy link
Owner

b20n commented Jan 15, 2017

Erm, why not use SSLClient vs. Client? It appears that this PR duplicates existing functionality.

@skob
Copy link
Author

skob commented Jan 15, 2017

I've left old class for backward compatibility, but much easier to inherit one class in children's code, not two different classes ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skob @b20n