Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make console redirection more generic #43

Open
rpalakkal opened this issue Nov 12, 2023 · 0 comments
Open

Make console redirection more generic #43

rpalakkal opened this issue Nov 12, 2023 · 0 comments
Labels
good first issue Good for newcomers halo2-lib-js Issues related to halo2-lib-js help wanted Extra attention is needed

Comments

@rpalakkal
Copy link
Contributor

Currently https://github.com/axiom-crypto/halo2-browser/blob/f3d696474d4be04809d6e3266c1841d2dc96d6bf/halo2-lib-js/src/shared/log.ts support redirection for log and time/timeEnd manually. Instead we should just take in a "logger" object that implements the console interface and then avoid assigning all the different console functions separately (instead, just override the entire console).
@rpalakkal rpalakkal added good first issue Good for newcomers help wanted Extra attention is needed halo2-lib-js Issues related to halo2-lib-js labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers halo2-lib-js Issues related to halo2-lib-js help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpalakkal