You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure which is the "correct" way, but I imagine the types should just be updated to reflect the actual code. (to prevent breaking change to existing consumer code)
The text was updated successfully, but these errors were encountered:
Title pretty much says it all, the type definitions for the returned
UserRecord
are incorrect.Here we can see they define the
data
property as aBuffer
:https://github.com/awslabs/kinesis-aggregation/blob/master/node/index.d.ts#L9
But in the actual code, it does not return
data
as aBuffer
, but a base64string
:https://github.com/awslabs/kinesis-aggregation/blob/master/node/lib/kpl-deagg.js#L97
We can see the example code showing that it is expecting a
string
object here:https://github.com/awslabs/kinesis-aggregation/blob/master/node/example/sample-deaggregation.js#L141
Not sure which is the "correct" way, but I imagine the types should just be updated to reflect the actual code. (to prevent breaking change to existing consumer code)
The text was updated successfully, but these errors were encountered: